Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR Feedback Fernanda Bonnin #364

Closed
WilcoFiers opened this issue May 24, 2019 · 5 comments
Closed

CR Feedback Fernanda Bonnin #364

WilcoFiers opened this issue May 24, 2019 · 5 comments

Comments

@WilcoFiers
Copy link
Collaborator

As Lisa Louise mentions it was thorough and understandable. The format of how the content was presented seems good too, I didn’t had to do a lot of jumping around to understand terms.

Two things that seem slightly confusing to me:

  • Why would you want to do complex aggregation? (in the Note: Rules can be used to do complex aggregation by describing the logic in the expectations. e.g. "The test target (the page) has a text alternative for 80% of all img elements".)

  • The document mentions that the rules can be evaluated: fully-automatically, semi-automatically, and manually. Then, in the implementations and data formats it's mentioned again with a description, but maybe an example of each type would be helpful.

@WilcoFiers
Copy link
Collaborator Author

Add a slight explanation go the note about "future guidelines".

Remove "semi-automatically" from the abstract.

nitedog pushed a commit that referenced this issue Jun 6, 2019
Tweaks to address the second bullet of issue #364 (removing "fully-automated, semi-automated, and manual testing" because they are not defined)
@WilcoFiers WilcoFiers removed their assignment Jun 26, 2019
@WilcoFiers
Copy link
Collaborator Author

@nitedog You're going to have to sort this one out. The abstract is part of Bikeshed. I can't change this in the repository.

@nitedog
Copy link
Contributor

nitedog commented Jun 27, 2019

The abstract is in the front-matter -- see PR #376

@WilcoFiers
Copy link
Collaborator Author

Proposed response

Thank you for your feedback. With regard to complex aggregation, the idea was to provide some insight into how future accessibility standards could go beyond a "pass or fail" model of accessibility. As for fully automated, semi-automated and manual. Those terms come from the Evaluation And Reporting Language (EARL). We acknoweldge that their use without further definition could be confusiong. Based on this feedback we have decided to avoid using the terms all together, as they serve no purpose in the ACT Rules Format.

nitedog pushed a commit that referenced this issue Jul 2, 2019
Closes #335 and addresses #364 

Some more elaboration on the example, and clarification of the use case and motivation for this.
@nitedog
Copy link
Contributor

nitedog commented Jul 2, 2019

Some clarification added to the note, also to address issue #335

WilcoFiers pushed a commit that referenced this issue Jul 8, 2019
Tweaks to address the second bullet of issue #364 (removing "fully-automated, semi-automated, and manual testing" because they are not defined)
WilcoFiers pushed a commit that referenced this issue Jul 8, 2019
Closes #335 and addresses #364 

Some more elaboration on the example, and clarification of the use case and motivation for this.
@nitedog nitedog closed this as completed Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants