Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made WCAG references consistent #350

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Made WCAG references consistent #350

merged 3 commits into from
Mar 29, 2019

Conversation

maryjom
Copy link
Collaborator

@maryjom maryjom commented Mar 26, 2019

Suggested edits to take care of Issue #323


Preview | Diff

@annethyme
Copy link

I searched (Ctrl + F) in the entire file and found a few more instances that might need a cleanup.

Maybe this one in line 520: "A common example of accessibility requirements are the WCAG 2.1 success criteria."

Also, the way we write out references to success criteria has a bit of variation when it comes to commas, capitalization and mention of SC numbers:

  • [WCAG 2.1 Audio Control] (line 290)
  • [WCAG 2.1, success criterion 1.2.3 Audio Description or Media Alternative] (line 355)
  • [WCAG 2.1 Success Criterion 1.4.3 Contrast (Minimum)] (line 377)
  • [WCAG 2.1 success criterion 4.1.3 Status messages] (line 392)

Other than that, it seems pretty consistent to me now.

Copy link
Member

@rdeltour rdeltour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
+1 on Anne's comment about the style consistency.

@maryjom
Copy link
Collaborator Author

maryjom commented Mar 28, 2019

I don't think line 520 necessarily needs to be changed as it is providing a specific example of a source of accessibility requirements. We'll see what the group thinks during the meeting.

@@ -517,7 +517,7 @@ Definitions {#definitions}
<dt><dfn>Accessibility requirement</dfn><dt>
<dd>
<p>A requirement is a condition that has to be satisfied in order to conform to a standard, or to comply with a contract, policy or regulation. An accessibility requirement is a requirement aimed at improving access for people with disabilities to an ICT product.</p>
<p>A common example of accessibility requirements are the WCAG 2.1 success criteria. There are other standards, including W3C standards, that have recommendations for accessibility, such as WAI-ARIA and HTML. Accessibility requirements are also often found in company policies, regional standards or in legislation.</p>
<p>A common example of accessibility requirements are the WCAG success criteria. There are other standards, including W3C standards, that have recommendations for accessibility, such as WAI-ARIA and HTML. Accessibility requirements are also often found in company policies, regional standards or in legislation.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "WCAG" be "Web Content Accessibility Guidelines [[WCAG]]" ?

@maryjom maryjom merged commit f708499 into master Mar 29, 2019
@maryjom maryjom deleted the WCAG20_or_21 branch April 2, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants