Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some pages have duplicate sections #3922

Open
kfranqueiro opened this issue Jun 25, 2024 · 2 comments
Open

Some pages have duplicate sections #3922

kfranqueiro opened this issue Jun 25, 2024 · 2 comments
Assignees
@patrickhlauke

Comments

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Jun 25, 2024 •
edited
Loading

The following pages have multiple sections with the same id and heading.

In one case, the XSLT build process preserves both sections separately but the table of contents links to the first, which contains duplicate content from the previous section; the Eleventy build process in #3917 correctly removes the earlier section to handle this particular issue until we resolve it.

  • 2.5.3 Label in Name: Benefits
    • The first of these is a subsection inside Intent, containing a partial repeat of Intent's content, which should be removed

In the other cases below, both build processes merge the duplicate sections together. The Eleventy process also prints a warning about it.

  • F61: Tests
    • Each of these seems to be unique; unsure whether one was intended to be removed
  • H63: Resources, Related
    • These duplicate sections contain essentially the same content; one of each should be removed
@kfranqueiro kfranqueiro mentioned this issue Jun 25, 2024
Open
@patrickhlauke patrickhlauke self-assigned this Jun 25, 2024
@kfranqueiro kfranqueiro mentioned this issue Jul 1, 2024
Merged
@kfranqueiro
Copy link
Contributor Author

FYI, I've addressed the Label in Name / Benefits instance in #3939, since that involved looking at nested Benefits sections anyway.

@kfranqueiro
Copy link
Contributor Author

H63 is addressed in #4009

mbgower added a commit that referenced this issue Aug 27, 2024
@kfranqueiro @mbgower
Make Benefits consistently a top-level section with h2 in source files (
1906ca8 
#3939)

Fixes #3924.

Also addresses the Label in Name instance in #3922.

The diff will be much easier to compare with whitespace ignored
(`?w=1`).

This amends all instances of the Benefits section in Understanding pages
to be a top-level section with a level-2 heading.

I've tested this with both the XSLT and Eleventy build processes to
confirm this doesn't actually change any content, since both build
processes already ensure Benefits is a top-level section with level-2
heading. The one exception is the removal of the redundant first
Benefits section in Understanding 2.5.3 Label in Name, which only
meaningfully affects the XSLT process, as the Eleventy process already
worked around that issue.

Note: I don't know what `identify-changes.html` is supposed to be, but I
updated it regardless; it seems to only contain template boilerplate and
is not linked from anywhere.

Co-authored-by: Mike Gower <mikegower@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickhlauke patrickhlauke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfranqueiro @patrickhlauke