Non-text contrast update #2028
Merged
Non-text contrast update #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <figure id="figure-focus-background"> | ||
| <img src="img/ntc-focus-background.png" alt="Three blue buttons, the center button is a lighter blue than the others." width="400" /> | ||
| <figcaption> | ||
| The change of background within the component is not in scope of non-text contrast. However, this would not pass <a href="../20/use-of-color.html">Use of color</a>. |
There was a problem hiding this comment.
didn't notice this at the time, but revisiting the google doc: while the change of just the background would fail use of color, the text of the button changes from white to black - the most dramatic change in contrast, which would not count as a change of color alone...so this would not fail Use of color?
There was a problem hiding this comment.
made this into a fresh issue #2061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from the doc agreed today.
Preview
Closes #1775