Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test for H71.html #3096

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Update test for H71.html #3096

merged 2 commits into from
Jul 10, 2024

Conversation

detlevhfischer
Copy link
Contributor

@detlevhfischer detlevhfischer commented Mar 8, 2023

Modify test section to include the requirement that legend is first child in fieldset, as is technically required

Closes #3090

Modify test section to include the requirement that legent is first child in fieldset
Coses  #3090
Copy link

@dd8 dd8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

fstrr
fstrr previously requested changes May 29, 2024
Copy link
Contributor

@fstrr fstrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you wrap the fieldset in "is the first child in the fieldset" in a <code class="language-html"> element please? Then it's good to go.

@fstrr
Copy link
Contributor

fstrr commented May 29, 2024

Also: wow, I didn't realise this was assigned to me. Sorry for taking over a year to see it.

techniques/html/H71.html Outdated Show resolved Hide resolved
Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
@fstrr fstrr requested a review from patrickhlauke May 29, 2024 17:08
@patrickhlauke patrickhlauke self-assigned this Jun 21, 2024
@mbgower mbgower changed the title Update H71.html Update test for H71.html Jun 24, 2024
@mbgower mbgower merged commit 17b1503 into main Jul 10, 2024
1 check passed
@mbgower mbgower deleted the h71-legent-first-child branch July 10, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test procedure in H71 doesn't require legend to be first child
5 participants