-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite technique C40 and associated example per discussion in #3026 #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user interface component"
I've updated this to cover:
The other example I'd mentioned considering in the PR description (two 1px bands at a 1px offset) would no longer pass the updated AAA focus appearance, so it's good that we never ended up including it anyway. |
alastc
reviewed
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates C40 and its associated examples per the discussion in #3026. Particularly:
outline: none
that can come up when trying to implement CSS similar to the recommended exampleI explored writing a second example using two 1px color bands offset slightly from the focused component. This type of indicator would pass in all the same scenarios as the first example, since the "adjacent contrast" test would be comparing against the same pixels that would have been background pixels for the first example. However, I didn't include an example because I didn't come up with a good technique for implementing it generally. The closest option I explored was along the lines of this:
...but I didn't feel comfortable with this as a general technique since it has issues with elements that can't accept
::after
content (eg, manyinput
types) and it can cause issues to overrideposition
so broadly like this.If someone has a bright idea for a more generally appropriate implementation, I'd be happy to include it as a second example.
This is the first time I've made changes this substantial to a technique, please feel free to have at me with any suggestions to help make the style more consistent with other techniques :)
Closes #3026
Closes #3055
Closes #2469
Closes #2575
Closes #2470
Preview C40, preview C41