Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CCA link text/url #3982

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Update CCA link text/url #3982

merged 1 commit into from
Aug 27, 2024

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Jul 21, 2024

This change simply updates/corrects the link target for the Colour Contrast Analyser

Copy link

netlify bot commented Jul 21, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 9503b51
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/669cd72fc2d39a000818ee43
😎 Deploy Preview https://deploy-preview-3982--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fstrr
Copy link
Contributor

fstrr commented Jul 29, 2024

Would it be more useful to link to the releases page rather than the repo homepage?

@patrickhlauke
Copy link
Member Author

Would it be more useful to link to the releases page rather than the repo homepage?

the homepage has the readme that explains what it's all about (but granted, for somebody unfamiliar with how github works, finding the releases may not be immediately obvious either)

@alastc
Copy link
Contributor

alastc commented Aug 16, 2024

And if anyone asks, the use of "Colour" is because it's the name of the product, so the US-spelling doesn't apply.

@ronsmantpg
Copy link

@alastc for the same reason, it should be "Analyser". The Colour Contrast Analyser product home page at https://www.tpgi.com/color-contrast-checker/ is in the process of being corrected.

@GreggVan
Copy link

why is "checker" being changed on the site to analyser? and if it was analyser -- then that was the name.

I suggest that it stick with the name Checker and avoid all this.

Also -- why is it called the Color/Colour contrast checker. It is checking luminance, not color contrast. We are not interested in whether the colors contrast (and what does it mean for colors to contrast? Just be suffiently different hues?)

Looks like a tempest in a teapot -- but if we are going to update the name I would suggest something that is accurate. and if we can avoid names that have words that are spelled differently in different countries it would make it easier to find.

best

@ronsmantpg
Copy link

@GreggVan the name of the tool is not being changed. It has always been Colour Contrast Analyser. This has, over the years, led to confusion, including on TPGi's own product web page (at least that is being corrected). The web address was changed from contrastanalyser to color-contrast-checker to try to remove some confusion (unsuccessfully), and maybe for SEO. Despite it being raised regularly, there are currently no plans to change the name.

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Aug 18, 2024

@GreggVan not quite sure what your angle is here. the tool is called "Colour Contrast Analyser". and has been called that since its creation. and this PR updates the link and the text that links to it to actually use the tool's name

Looks like a tempest in a teapot

not sure where you're getting this impression from.

if we are going to update the name

we aren't going to update the name of the tool. we are only changing the link to it to use the correct product name. because we (AGWG) don't own the tool, TPGi does...

@GreggVan
Copy link

@patrickhlauke
I don't know what you mean by "what's your angle". Do people have "angles" when they comment?

I know what the tool's name is -- and how long it has had it. I was the one who commissioned (paid for) the adding of the WCAG analysis to the tool long before TPG took it over and the refactored it etc.

RE my comments about the name

a) the TPG link (not ours) is https://www.tpgi.com/color-contrast-checker/ So the TPG link is already "checker" not "analyser/analyzer". Someone suggested we tell TPG to change the name in the link. I suggested that if they changed the name of the tool to checker - it would match the link and solve the problem with different languages.

b) then I noted that colour/color was also back and forth. So to make it also use a word that was region-neutral and more accurate we might suggest they change the name to Contrast Checker since it doesnt actually measure how much the colors (hue and lightness) contrast with other colors but how much the luminosity (lightness / darkness) of samples differ. This would solve a lot of misconceptions about the tool and colors and contrast. But I have never pushed for it because it didnt seem like something people wanted to do. So we will just have to keep explaining. (funny how it is so hard to change things. Machiavelli has a great quote on change

RE tempest in teapot -
I ended comment by saying that I thought it was just fine to leave things as they are -- that all this "we need to change the link" was a lot of airtime over something that was unlikely to change -- and the link was actually easier for people to understand (as was intended) than using a word people might misspell and not get the tool.

So I am signing off on this thread --to not waste more airtime. TPG will decide on the name and URL and we will just use what they use. It is evident from @ronsmantpg 's comments that all this is already things they have thought about -- and decided. So. Ciao for now

@mbgower mbgower merged commit 5dd3f70 into main Aug 27, 2024
5 checks passed
@mbgower mbgower deleted the patrickhlauke-update-cca-link branch August 27, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants