-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech fitting labels inputs viewport #509
Tech fitting labels inputs viewport #509
Conversation
|
#510 related |
Hi Jake, Now that we have the working-examples folder setup ok, you can create examples in the same branch. I think it stops a lot of the faffing... |
Hi Jake, other branch merged into this (so this one is remaining open) and a few little wording updates applied. |
Just noting for @allanj-uaag, @rachaelbradley and @lauracarlson that the example has been combined into this PR, so comments from #510 apply here. I think the comments have been addressed, but worth checking. |
Since the comment field is missing for this technique in the Survey, I'm putting comments here. In the title, I think the "width" "max-width" and maybe "flexbox" should be in code tags. Second paragraph, for the text
Add "horizontal" to read "...cause horizontal scrolling." For first example, the text
replace "scrolling in more than one direction" with "horizontal scrolling". I believe the technique is sufficiently restricted that it only applies to preventing horizontal formatting, and thus can be specific here. (But on a side note, how about instead of saying 'in more than one direction' we say 'on more than one plane' which is more accurate and less confusing, at least for me). and for the text
replace "like" with "such as" and put "select" inside a code tag The test is backwards, and also needs to be reworded NOT to check (that is done in the check)
should be
For the working example, I think the title could be better. Maybe 'Adjustable Labels and Inputs for Reflow'. I also think there could be a bit of an instruction at the end of the first paragraph. Just add the two first steps in the procedure" |
…com/w3c/wcag into tech-fitting-labels-inputs-viewport
…com/w3c/wcag into tech-fitting-labels-inputs-viewport
@michael-n-cooper I think it's ready. I did a test build, updated the file names, and updated the understanding document. Please merge if it's ok, comment if there's anything I missed. |
New technique for Using Fitting Labels and Inputs for Reflow, you can preview Using Fitting Labels and Inputs for Reflow, and there is an associated example page.