Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech fitting labels inputs viewport #509

Merged
merged 27 commits into from
Nov 30, 2018

Conversation

jake-abma
Copy link
Contributor

@jake-abma jake-abma commented Oct 9, 2018

New technique for Using Fitting Labels and Inputs for Reflow, you can preview Using Fitting Labels and Inputs for Reflow, and there is an associated example page.

@jake-abma
Copy link
Contributor Author

  • paragraph starting "Layouts..." changed
  • Removed: "Medium complex"

@jake-abma
Copy link
Contributor Author

#510 related

@alastc alastc added Techniques Ready for initial review A new technique ready for +1s or itterations labels Nov 20, 2018
@alastc
Copy link
Contributor

alastc commented Nov 20, 2018

Hi Jake,

Now that we have the working-examples folder setup ok, you can create examples in the same branch. I think it stops a lot of the faffing...

@alastc
Copy link
Contributor

alastc commented Nov 21, 2018

Hi Jake, other branch merged into this (so this one is remaining open) and a few little wording updates applied.

@alastc
Copy link
Contributor

alastc commented Nov 21, 2018

Just noting for @allanj-uaag, @rachaelbradley and @lauracarlson that the example has been combined into this PR, so comments from #510 apply here.

I think the comments have been addressed, but worth checking.

@alastc alastc added Ready for WG Review and removed Ready for initial review A new technique ready for +1s or itterations labels Nov 22, 2018
@mbgower
Copy link
Contributor

mbgower commented Nov 27, 2018

Since the comment field is missing for this technique in the Survey, I'm putting comments here.

In the title, I think the "width" "max-width" and maybe "flexbox" should be in code tags.

Second paragraph, for the text

including in one-column layouts where it would cause scrolling.

Add "horizontal" to read "...cause horizontal scrolling."

For first example, the text

without requiring scrolling in more than one direction

replace "scrolling in more than one direction" with "horizontal scrolling". I believe the technique is sufficiently restricted that it only applies to preventing horizontal formatting, and thus can be specific here. (But on a side note, how about instead of saying 'in more than one direction' we say 'on more than one plane' which is more accurate and less confusing, at least for me).

and for the text

as replaced elements like the select have intrinsic sizing.

replace "like" with "such as" and put "select" inside a code tag

The test is backwards, and also needs to be reworded NOT to check (that is done in the check)

For horizontally scrolling content, check that all labels and inputs fit in their available space without vertical scrolling

should be

For vertically scrolling content, all labels and inputs fit in their available space without horizontal scrolling

For the working example, I think the title could be better. Maybe 'Adjustable Labels and Inputs for Reflow'. I also think there could be a bit of an instruction at the end of the first paragraph. Just add the two first steps in the procedure"
"Display the web page in a user agent capable of 400% zoom and set the viewport dimensions (in CSS pixels) to 1280 wide and 1024 high. Zoom in by 400%."

@alastc
Copy link
Contributor

alastc commented Nov 29, 2018

@michael-n-cooper I think it's ready. I did a test build, updated the file names, and updated the understanding document. Please merge if it's ok, comment if there's anything I missed.

@michael-n-cooper michael-n-cooper merged commit ca4b9e7 into master Nov 30, 2018
@patrickhlauke patrickhlauke deleted the tech-fitting-labels-inputs-viewport branch September 16, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants