Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech control orientation #794

Merged
merged 29 commits into from
Jul 16, 2019
Merged

Tech control orientation #794

merged 29 commits into from
Jul 16, 2019

Conversation

awkawk
Copy link
Member

@awkawk awkawk commented Jun 19, 2019

@awkawk awkawk self-assigned this Jun 19, 2019
@awkawk awkawk added the Ready for initial review A new technique ready for +1s or itterations label Jun 19, 2019
@patrickhlauke
Copy link
Member

One aspect that may be confusing here is that in general (at least for phone/tablet use), users engage orientation locks at the OS level when they want to lock things into a certain orientation (i.e. in portrait mode, they lock it into that mode before lying on their side). But I gather you mean here is that it's the content itself that is doing the locking, counteracting what the normal behaviour would be - which would be a failure on its own - but is offering a custom control to then also allow orientation switching - making it ok again in light of the SC?

Maybe see if it can be emphasised that by default the content would adapt to landscape mode, but that the developer has explicitly counteracted this / locked the orientation, to cater for the "reading on their side" use case?

@patrickhlauke
Copy link
Member

also...is the example of an e-Reader application appropriate for web content guidelines? the e-Reader would be like a user agent of sorts. maybe at least e-Reader web application?

@awkawk
Copy link
Member Author

awkawk commented Jun 19, 2019

@patrickhlauke sure - web app

@awkawk
Copy link
Member Author

awkawk commented Jun 19, 2019

@patrickhlauke It may seem a bit backward relative to what we would hope people do, but here's the logic:

  1. The SC exists because people do restrict content to one viewing orientation or another.
  2. Some people may feel that there is a good reason to do this.
  3. This technique provides a way for them to still conform.

Perhaps what we should add is a note that says:
Many users will expect to use OS-level settings to prevent the orientation changing, so it is usually preferable to satisfy this Success Criterion by not restricting the content's ability to adapt to changes in orientation and allowing users to use the OS orientation lock when desired.

@patrickhlauke
Copy link
Member

On second reading, having worked out the intent, it actually sounded ok. But yes, having a note along those lines could help.

Andrew Kirkpatrick and others added 3 commits June 25, 2019 11:02
slight rewording for readability
made orient re-orient
@mbgower
Copy link
Contributor

mbgower commented Jul 12, 2019

Created #821 to address some readability issues

@alastc alastc merged commit 6c188ef into master Jul 16, 2019
@alastc alastc deleted the tech-control-orientation branch July 16, 2019 20:47
@alastc alastc added Survey - Accepted and removed Ready for initial review A new technique ready for +1s or itterations Survey - Added labels Jul 16, 2019
@alastc
Copy link
Contributor

alastc commented Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants