Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use 'any' to define NDEFRecordInit#data #453

Closed
leonhsl opened this issue Nov 27, 2019 · 2 comments · Fixed by #454
Closed

Do not use 'any' to define NDEFRecordInit#data #453

leonhsl opened this issue Nov 27, 2019 · 2 comments · Fixed by #454
Assignees
@beaufortfrancois

Comments

@leonhsl
Copy link
Contributor

leonhsl commented Nov 27, 2019

I remember someone before gave a comment about not using any as possible as we can when doing Web IDL design, but I can not point out the exact place now.

Based on that I'd propose changing NDEFRecordInit#data from any type to
typedef (DOMString or BufferSource or NDEFMessageInit) NDEFRecordDataSource;,
which should just be enough. (See https://w3c.github.io/web-nfc/#data-mapping)

@reillyeon @riju @beaufortfrancois @zolkis @kenchris
@beaufortfrancois
Copy link
Collaborator

That looks good to me. I'll draft a PR.

@beaufortfrancois beaufortfrancois self-assigned this Nov 27, 2019
@beaufortfrancois beaufortfrancois mentioned this issue Nov 27, 2019
Merged
@beaufortfrancois
Copy link
Collaborator

PR is available at #454.
Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beaufortfrancois beaufortfrancois

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not use 'any' to define NDEFRecordInit#data beaufortfrancois/web-nfc
2 participants
@beaufortfrancois @leonhsl