Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a list of device IDs we will explicitly block in Web NFC #550

Closed
beaufortfrancois opened this issue Mar 12, 2020 · 7 comments · Fixed by #553
Closed

Create a list of device IDs we will explicitly block in Web NFC #550

beaufortfrancois opened this issue Mar 12, 2020 · 7 comments · Fixed by #553

Comments

@beaufortfrancois
Copy link
Collaborator

We should create a list, similar to the ones in the WebUSB and Web Bluetooth repos, of device IDs we are explicitly blocking. The first ones to be included will be YubiKey devices as raised in #543

Here's the WebUSB blocklist: https://github.com/WICG/webusb/blob/master/blocklist.txt

For info, here's the chromium CL that introduces the blocklist: https://chromium-review.googlesource.com/c/chromium/src/+/2078550

@beaufortfrancois
Copy link
Collaborator Author

It could look like as something like this

# Historical bytes

0x80, 0x73, 0xc0, 0x21, 0xc0, 0x57, 0x59, 0x75, 0x62, 0x69, 0x4b, 0x65, 0x79 #YubiKey 5 Series
0x59, 0x75, 0x62, 0x69, 0x6b, 0x65, 0x79, 0x4e, 0x45, 0x4f, 0x72, 0x33 # YubiKey NEO 

@beaufortfrancois
Copy link
Collaborator Author

cc @reillyeon

@reillyeon
Copy link
Member

We should make sure that the fields being matched are well-defined in terms of the NFC specifications. I'm not sure if "historical bytes" is a term from NFC or the Android API.

@miguelUS
Copy link

So are YubiKeys NFC blocked from Web NFC?
Can a developer remove the blocking if he/she chooses to?

@beaufortfrancois
Copy link
Collaborator Author

beaufortfrancois commented Feb 24, 2022

@miguelUS
Copy link

Thanks. My use case is: a customer wants to read a Yubico OTP string (the 44 character string you get from the YubiKey) into a web browser tab (chrome custom tab) and use it as second factor for authentication through NFC. The device is Android.

@beaufortfrancois
Copy link
Collaborator Author

Yes. This Blocklist is there to block this kind of attacks. See discussion at #543 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants