Join Reader and Writer objects

[kenchris]

I take the blame for this. It originally seemed like a good idea with separate objects, but I am getting more and more convinced that it was a bad idea.

• If we enhance to be able to select tag in the case of multiple tags read, this is required
• TNEP also requires this
• We can get rid of ignoreRead
• User is more in control of what happens.

Suggested name NDEFPoller or NDEFPollerDevice

[OlivierGrenoble]

If we enhance to be able to select tag in the case of multiple tags read, this is required

On Android, it is not possible to select one tag among several tags. There should be only one in the RF field.

[reillyeon]

I vote for calling the combined object NDEFReader. The physical hardware components for NFC seem to usually be called a "reader" even though they can also write. It doesn't seem necessary to find a new (potentially awkward) word to describe it.

[kenchris]

I need to get hand on the new NFC TNEP spec, but it looks like they used poller device (vs tag device) but I need to confirm

[OlivierGrenoble]

I vote for calling the combined object NDEFReader. The physical hardware components for NFC seem to usually be called a "reader" even though they can also write. It doesn't seem necessary to find a new (potentially awkward) word to describe it.

I agree

[kenchris]

I checked the new spec and it seems that the Poller thing was just what Nordic named it in their API.

Currently the following NFC Forum Devices are defined:

• NFC Universal Device
• NFC Tag Device
• NFC Reader Device.

[zolkis]

I vote for calling the combined object NDEFReader

Currently the following NFC Forum Devices are defined:
NFC Universal Device
NFC Tag Device
NFC Reader Device

Ergo what about NFCReader, bearing in mind possible future support for NDEF+other tech for a given device?

Edit.
In fact, pondering whether NFCDevice or NDEFDevice would be better. Think about e.g. Example 2.

const writer = new NDEFWriter();
writer.write(
  "Hello World"
).then(() => {
  console.log("Message written.");
}).catch(error => {
  console.log(`Write failed :-( try again: ${error}.`);
});

If we used NDEFReader, we created reader and use it for writing.

const reader = new NDEFReader();
reader.write(
  "Hello World"
).then(() => {
  console.log("Message written.");
}).catch(error => {
  console.log(`Write failed :-( try again: ${error}.`);
});

I know we could call it const ndef = new NDEFReader(); as well, but maybe would look better this way:

const ndef = new NFCDevice();
ndef.write(
  "Hello World"
).then(() => {
  console.log("Message written.");
}).catch(error => {
  console.log(`Write failed :-( try again: ${error}.`);
});

[reillyeon]

I'd be cautious about assuming that the existing API can be extended to support future technologies. Keeping the API focused on NDEF allows us to only consider a subset of all possible NFC interactions and built the best API for that.

[zolkis]

Discussed with Kenneth that we'd likely stick with NDEFReader that will have a write() method :).

[kenchris]

Fixed on branch: 00509fc

[kenchris]

Merged upstream