Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method for clearing all watches? #85

Closed
zolkis opened this issue Nov 3, 2015 · 2 comments
Closed

Add method for clearing all watches? #85

zolkis opened this issue Nov 3, 2015 · 2 comments

Comments

@zolkis
Copy link
Contributor

zolkis commented Nov 3, 2015

From @alexshalamov: should we provide way to clear all watches?

If developer is "sloppy" and don't save watch ids, should we provide way to clear all watches?
Would developers use it more than single clearWatch()? Or wait until a clear need arises?

Or just make parameter optional, and if no id provided to clearWatch(), then clear all watches?
@kenchris
Copy link
Contributor

kenchris commented Nov 3, 2015

cancelAllWatches() should suffice for now, until we get CancellablePromises, and still make sense when we do. Similar to #86

zolkis added a commit to zolkis/web-nfc that referenced this issue Nov 4, 2015
@zolkis
Fix w3c#71, w3c#83, w3c#85. Handle watch related TAG review comments:…
f06aa12 
… fix IDL for unwatch(), reverse param order for watch() and make options optional, make cancelPush target optional.
@zolkis zolkis mentioned this issue Nov 4, 2015
Merged
@zolkis
Copy link
Contributor Author

zolkis commented Nov 6, 2015

Fixed by #88.

@zolkis zolkis closed this as completed Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zolkis @kenchris