Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watch API should have the options dictionary as a second parameter #71

Closed
kenchris opened this issue Oct 15, 2015 · 2 comments · Fixed by #88
Closed

watch API should have the options dictionary as a second parameter #71

kenchris opened this issue Oct 15, 2015 · 2 comments · Fixed by #88
Labels
tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response.

Comments

@kenchris
Copy link
Contributor

https://github.com/w3ctag/spec-reviews/blob/master/2015/10/nfc-feedback.md

By convention, the watch API should have the options dictionary as a second parameter (not vice-versa). This will also allow the dictionary to be optional, which it is already setup for.
@kenchris
Copy link
Contributor Author

Unfortunately that means that user code might "hide" the filtering, like

watch(function() {

  // long body.

}, filter)

@zolkis
Copy link
Contributor

zolkis commented Oct 15, 2015

No strong opinion on this, either way works for me.

zolkis added a commit to zolkis/web-nfc that referenced this issue Nov 4, 2015
@zolkis
Fix w3c#71, w3c#83, w3c#85. Handle watch related TAG review comments:…
f06aa12 
… fix IDL for unwatch(), reverse param order for watch() and make options optional, make cancelPush target optional.
@zolkis zolkis mentioned this issue Nov 4, 2015
Merged
@zolkis zolkis closed this as completed in #88 Nov 6, 2015
@plehegar plehegar added the tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response. label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TAG review comments. zolkis/web-nfc
3 participants
@zolkis @kenchris @plehegar