Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancelPush should return Promise<void> #83

Closed
alexshalamov opened this issue Oct 30, 2015 · 1 comment
Closed

cancelPush should return Promise<void> #83

alexshalamov opened this issue Oct 30, 2015 · 1 comment

Comments

@alexshalamov
Copy link

On some platforms, cancellation of "pushed" NFC message is async operation and can fail or raise exception. It would be better if cancelPush would return Promise
zolkis added a commit to zolkis/web-nfc that referenced this issue Nov 4, 2015
@zolkis
Fix w3c#69, w3c#70, w3c#73, w3c#77, w3c#80, w3c#81, w3c#82, w3c#83, w…
12b905d 
…3c#84. Handle push related TAG review comments: simplified and aligned push message, optional push options with sensible defaults, improved push and cancelPush steps, option for suspending watches during push(), editorials.
zolkis added a commit to zolkis/web-nfc that referenced this issue Nov 4, 2015
@zolkis
Fix w3c#71, w3c#83, w3c#85. Handle watch related TAG review comments:…
f06aa12 
… fix IDL for unwatch(), reverse param order for watch() and make options optional, make cancelPush target optional.
@zolkis zolkis mentioned this issue Nov 4, 2015
Merged
@zolkis
Copy link
Contributor

zolkis commented Nov 6, 2015

Fixed by #88.

@zolkis zolkis closed this as completed Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zolkis @alexshalamov