Remove ignoreRead and add info on how to implement manually #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolkis
reviewed
May 1, 2020
| <section><h3>Write a text string</h3> | ||
| <p> | ||
| Writing a text string to an NFC tag is straightforward. | ||
| Writing a text string to an NFC tag is straight-forward. |
There was a problem hiding this comment.
straightforward was fine
https://www.merriam-webster.com/dictionary/straightforward
There was a problem hiding this comment.
Then I need to fix in more places
zolkis
reviewed
May 1, 2020
| @@ -1180,7 +1322,7 @@ <h4> | |||
| }; | |||
|
|
|||
| // Stop listening to NDEF messages after 3s. | |||
| setTimeout(() => controller.abort(), 3000); | |||
| setTimeout(() => controller.abort(), 3_000); | |||
There was a problem hiding this comment.
zolkis
reviewed
May 1, 2020
| If polling is not initiated already by first calling `scan()`, | ||
| then the `write()` method will initiate it temporarily until a | ||
| tag was found and read, and writing to it was attempted. | ||
| </p> |
There was a problem hiding this comment.
This is not explicitly said in the write() steps, but it's indeed implicitly assumed.
There was a problem hiding this comment.
It's not said in write steps either which might be the reason why we have the read after writing if scan is not called
There was a problem hiding this comment.
Also we should probably talk about the polling and NFC Read operation as used in the NFC specs (at least tnep)
zolkis
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add more info about how writing works and an example on how to timeout a write, as well as how to construct a method that allows reading just one tag.
Preview | Diff