Remove invisible special characters at the beginning of websocket.js

[Honry]

No description provided.

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/391

This is an external review system which you may optionally use for the code review of your pull request.

[Ms2ger]

It seems like any sofware that deals with the web will need to support BOMs, so I don't quite understand why this change is necessary.

[Honry]

I test the websocket case on my Crosswalk device, it raised “CreateWebSocket is not defined” exception, I found it loaded the websocket.js file failed in the case because of the invisible special characters at the beginning of websocket.js. And we remove it, then the test passes.

[Honry]

hi, Ms2ger

Could you please help explain "BOMs"? I'm not sure what it means.

[Ms2ger]

What you removed is the UTF-8 BOM.

[zqzhang]

Hi @Ms2ger, thank you for the comments. While I agree to 'any sofware that deals with the web will need to support BOMs', I still wonder if this character is a MUST for this file?

[sideshowbarker]

@zqzhang Nobody said that having a BOM in this file is a must. Instead the point is that removing it is not a must. It's not necessary to remove it because there's nothing broken in the file. If Crosswalk in fact can't deal correctly with BOMs in JS files, then Crosswalk is broken and needs to be fixed.

[zqzhang]

@sideshowbarker, got it, thanks.

[Honry]

Thanks for your all comments, I will close this PR.