Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use travis-provided branch range as commit base, where possible #4821

Merged
merged 2 commits into from
Mar 16, 2017
Merged

Use travis-provided branch range as commit base, where possible #4821

merged 2 commits into from
Mar 16, 2017

Conversation

jgraham
Copy link
Contributor

@jgraham jgraham commented Feb 14, 2017

No description provided.

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot commented Feb 14, 2017 •
edited by tobie
Loading

Notifying @Ms2ger, @ayg, @jdm, @zcorpan, and @zqzhang. (Learn how reviewing works.)

@wpt-stability-bot
Copy link

wpt-stability-bot commented Feb 14, 2017 •
edited
Loading

Firefox (nightly channel)

Testing revision 3eaa1d7
Starting 10 test iterations
All results were stable

All results

/dom/historical.html
Subtest Results
OK
Event should not have this constant: DRAGDROP PASS
Historical DOM features must be removed: Entity PASS
Historical DOM features must be removed: schemaTypeInfo PASS
Node member must be nuked: attributes PASS
Node member must be nuked: getUserData PASS
Historical DOM features must be removed: xmlVersion PASS
Historical DOM features must be removed: setIdAttributeNS PASS
Historical DOM features must be removed: DOMUserData PASS
Historical DOM features must be removed: width PASS
Historical DOM features must be removed: setIdAttributeNode PASS
Event should not have this constant: BLUR PASS
Historical DOM features must be removed: DOMError FAIL
Event should not have this constant: CLICK PASS
DocumentType member must be nuked: notations PASS
document.load PASS
Historical DOM features must be removed: async FAIL
Historical DOM features must be removed: DOMImplementationSource PASS
Historical DOM features must be removed: DOMSettableTokenList PASS
Event should not have this constant: MOUSEUP PASS
Event should not have this constant: DBLCLICK PASS
Event should not have this constant: MOUSEMOVE PASS
Historical DOM features must be removed: EventException PASS
Node member must be nuked: setUserData PASS
DOMImplementation.getFeature() must be nuked. PASS
Historical DOM features must be removed: RangeException PASS
Event should not have this constant: CHANGE PASS
Historical DOM features must be removed: renameNode PASS
Event should not have this constant: MOUSEDOWN PASS
Historical DOM features must be removed: normalizeDocument PASS
Historical DOM features must be removed: DOMConfiguration PASS
Event should not have this constant: MOUSEDRAG PASS
Historical DOM features must be removed: DOMObject PASS
Historical DOM features must be removed: NameList PASS
Historical DOM features must be removed: xmlEncoding PASS
Historical DOM features must be removed: UserDataHandler PASS
Node member must be nuked: hasAttributes PASS
Attr member must be nuked: schemaTypeInfo PASS
Historical DOM features must be removed: domConfig PASS
Historical DOM features must be removed: DOMImplementationList PASS
Window member must be nuked: attachEvent PASS
Historical DOM features must be removed: DOMErrorHandler PASS
Historical DOM features must be removed: strictErrorChecking PASS
Historical DOM features must be removed: Notation PASS
Node member must be nuked: getFeature PASS
Historical DOM features must be removed: DOMLocator PASS
Event should not have this constant: KEYUP PASS
Event should not have this constant: MOUSEOVER PASS
Event should not have this constant: FOCUS PASS
Node member must be nuked: namespaceURI PASS
Event should not have this constant: KEYPRESS PASS
Historical DOM features must be removed: commands PASS
Historical DOM features must be removed: xmlStandalone PASS
Attr member must be nuked: isId PASS
Node member must be nuked: prefix PASS
Node member must be nuked: rootNode PASS
Event should not have this constant: MOUSEOUT PASS
Historical DOM features must be removed: setIdAttribute PASS
Event should not have this constant: SELECT PASS
Historical DOM features must be removed: TypeInfo PASS
Historical DOM features must be removed: createEntityReference PASS
Text member must be nuked: replaceWholeText PASS
Historical DOM features must be removed: height PASS
DocumentType member must be nuked: entities PASS
Node member must be nuked: isSupported PASS
Node member must be nuked: localName PASS
DocumentType member must be nuked: internalSubset PASS
Historical DOM features must be removed: EntityReference PASS
Event should not have this constant: KEYDOWN PASS
Text member must be nuked: isElementContentWhitespace PASS
Historical DOM features must be removed: cssElementMap PASS
Historical DOM features must be removed: defaultCharset PASS

@wpt-stability-bot
Copy link

wpt-stability-bot commented Feb 14, 2017 •
edited
Loading

Chrome (unstable channel)

Testing revision 3eaa1d7
Starting 10 test iterations
All results were stable

All results

/dom/historical.html
Subtest Results
OK
Event should not have this constant: DRAGDROP FAIL
Historical DOM features must be removed: Entity PASS
Historical DOM features must be removed: schemaTypeInfo PASS
Node member must be nuked: attributes PASS
Node member must be nuked: getUserData PASS
Historical DOM features must be removed: xmlVersion FAIL
Historical DOM features must be removed: setIdAttributeNS PASS
Historical DOM features must be removed: DOMUserData PASS
Historical DOM features must be removed: width PASS
Historical DOM features must be removed: setIdAttributeNode PASS
Event should not have this constant: BLUR FAIL
Historical DOM features must be removed: DOMError FAIL
Event should not have this constant: CLICK FAIL
DocumentType member must be nuked: notations PASS
document.load PASS
Historical DOM features must be removed: async PASS
Historical DOM features must be removed: DOMImplementationSource PASS
Historical DOM features must be removed: DOMSettableTokenList PASS
Event should not have this constant: MOUSEUP FAIL
Event should not have this constant: DBLCLICK FAIL
Event should not have this constant: MOUSEMOVE FAIL
Historical DOM features must be removed: EventException PASS
Node member must be nuked: setUserData PASS
DOMImplementation.getFeature() must be nuked. PASS
Historical DOM features must be removed: RangeException PASS
Event should not have this constant: CHANGE FAIL
Historical DOM features must be removed: renameNode PASS
Event should not have this constant: MOUSEDOWN FAIL
Historical DOM features must be removed: normalizeDocument PASS
Historical DOM features must be removed: DOMConfiguration PASS
Event should not have this constant: MOUSEDRAG FAIL
Historical DOM features must be removed: DOMObject PASS
Historical DOM features must be removed: NameList PASS
Historical DOM features must be removed: xmlEncoding FAIL
Historical DOM features must be removed: UserDataHandler PASS
Node member must be nuked: hasAttributes PASS
Attr member must be nuked: schemaTypeInfo PASS
Historical DOM features must be removed: domConfig PASS
Historical DOM features must be removed: DOMImplementationList PASS
Window member must be nuked: attachEvent PASS
Historical DOM features must be removed: DOMErrorHandler PASS
Historical DOM features must be removed: strictErrorChecking PASS
Historical DOM features must be removed: Notation PASS
Node member must be nuked: getFeature PASS
Historical DOM features must be removed: DOMLocator PASS
Event should not have this constant: KEYUP FAIL
Event should not have this constant: MOUSEOVER FAIL
Event should not have this constant: FOCUS FAIL
Node member must be nuked: namespaceURI PASS
Event should not have this constant: KEYPRESS FAIL
Historical DOM features must be removed: commands PASS
Historical DOM features must be removed: xmlStandalone FAIL
Attr member must be nuked: isId PASS
Node member must be nuked: prefix PASS
Node member must be nuked: rootNode PASS
Event should not have this constant: MOUSEOUT FAIL
Historical DOM features must be removed: setIdAttribute PASS
Event should not have this constant: SELECT FAIL
Historical DOM features must be removed: TypeInfo PASS
Historical DOM features must be removed: createEntityReference PASS
Text member must be nuked: replaceWholeText PASS
Historical DOM features must be removed: height PASS
DocumentType member must be nuked: entities PASS
Node member must be nuked: isSupported PASS
Node member must be nuked: localName PASS
DocumentType member must be nuked: internalSubset PASS
Historical DOM features must be removed: EntityReference PASS
Event should not have this constant: KEYDOWN FAIL
Text member must be nuked: isElementContentWhitespace PASS
Historical DOM features must be removed: cssElementMap PASS
Historical DOM features must be removed: defaultCharset PASS

@jgraham jgraham force-pushed the commit_base branch 15 times, most recently from c7386a3 to 7264826 Compare February 14, 2017 22:33
@jgraham
Copy link
Contributor Author

jgraham commented Feb 14, 2017

r? @bobholt

@jgraham
Use travis-provided branch range as commit base, where possible.
63b209b 
This fixes a problem where PRs not against master included all the commits
in their branch in the stability check, rather than just the changes since
the base branch.
@jgraham
Stop running manifest diff job in CI.
b8373b8 
No one looks at the results and it's mostly redundant with the stability checker output.
@jugglinmike jugglinmike merged commit 7f8ae02 into master Mar 16, 2017
@jugglinmike
Copy link
Contributor

Thanks, James!

@w3c-bots
Copy link

These tests are now available on w3c-test.org

@jugglinmike
Copy link
Contributor

@bobholt Above, the bot appears to have built this branch in response to the merge event. My guess is that it is subscribed to one event too many. Whatever the case, I think you'll agree that this inefficiency is pretty low-priority. Just wanted to give you a heads-up!

@zcorpan zcorpan deleted the commit_base branch March 17, 2017 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jugglinmike jugglinmike jugglinmike left review comments

@bobholt bobholt bobholt requested changes

Assignees
No one assigned
Labels
dom infra wg-css wg-geolocation wg-html wg-i18n_core wg-payments wg-pointerevents wg-secondscreen wg-webapps wg-webappsec wg-webcrypto wg-webperf wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jgraham @wpt-pr-bot @wpt-stability-bot @w3c-bots @foolip @jugglinmike @bobholt @tobie @annevk