Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: Resolve p with undefined #43

Closed
mgiuca opened this issue Jun 21, 2017 · 0 comments
Closed

Spec: Resolve p with undefined #43

mgiuca opened this issue Jun 21, 2017 · 0 comments

Comments

@mgiuca
Copy link
Collaborator

mgiuca commented Jun 21, 2017

Minor nit pointed out by @foolip here --- you can't just "resolve" a promise, even if it's void, need to resolve "with undefined".
mgiuca added a commit to mgiuca/web-share that referenced this issue Jun 21, 2017
@mgiuca
Explicitly resolve promise with undefined.
7efc620 
Closes w3c#43.
mgiuca added a commit to mgiuca/web-share that referenced this issue Jun 21, 2017
@mgiuca
Explicitly resolve promise with undefined.
4e28a76 
Closes w3c#43.
This was referenced Jun 21, 2017
Merged
Merged
@mgiuca mgiuca closed this as completed in 786a14a Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgiuca