Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove canShare method? #5

Closed
mgiuca opened this issue Jul 20, 2016 · 0 comments
Closed

Remove canShare method? #5

mgiuca opened this issue Jul 20, 2016 · 0 comments

Comments

@mgiuca
Copy link
Collaborator

mgiuca commented Jul 20, 2016

As discussed with @marcoscaceres yesterday, the canShare method may be unnecessary.

Since it provides no actual arguments to query exactly what actions are supported, and any implementation of Web Share is likely to have at least one default action, it's likely that canShare would simply always return true in any implementation. Therefore, people would not check it and it would probably break sites if a rare implementation returned false. So we might just drop it (and sites can use the presence of navigator.share itself to detect whether sharing is supported).

On the other hand, if we are going to share more interesting types of data (like files, images, etc), there may be different sets of apps that can handle these data types, and we may want canShare to take an argument that describes the data, to see if there is an app that can handle that particular type.

mgiuca added a commit to mgiuca/web-share that referenced this issue Jul 21, 2016
mgiuca added a commit to mgiuca/web-share that referenced this issue Sep 29, 2016
@mgiuca mgiuca closed this as completed in #8 Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant