Skip to content

Commit

Permalink
Align RP ID string types
Browse files Browse the repository at this point in the history
`rp.id` in `PublicKeyCredentialCreationOptions` and `rpId` in
`PublicKeyCredentialRequestOptions` represent the same thing, but with
different types. The WG agreed on the 2024-05-15 that both should be
`USVString`. Strictly speaking this is a breaking change (changing a
type bound in input (contravariant) position to be more restrictive),
but in practice this shouldn't be able to break any applications since
then those credentials wouldn't have worked in `get()` anyway.
  • Loading branch information
emlun committed May 20, 2024
1 parent 62b069e commit f435928
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -2906,7 +2906,7 @@ value and terminate the operation.
dictionary PublicKeyCredentialRequestOptionsJSON {
required Base64URLString challenge;
unsigned long timeout;
DOMString rpId;
USVString rpId;
sequence<PublicKeyCredentialDescriptorJSON> allowCredentials = [];
DOMString userVerification = "preferred";
sequence<DOMString> hints = [];
Expand Down Expand Up @@ -3235,7 +3235,7 @@ The {{PublicKeyCredentialRpEntity}} dictionary is used to supply additional [=[R

<xmp class="idl">
dictionary PublicKeyCredentialRpEntity : PublicKeyCredentialEntity {
DOMString id;
USVString id;
};
</xmp>

Expand Down

0 comments on commit f435928

Please sign in to comment.