Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move extension specification out of signature format #7

Closed
equalsJeffH opened this issue Mar 13, 2016 · 4 comments
Closed

Move extension specification out of signature format #7

equalsJeffH opened this issue Mar 13, 2016 · 4 comments
Labels
stat:OKtoDo type:editorial
Milestone
FPWD (WD-00)

Comments

@equalsJeffH
Copy link
Contributor

Originally submitted by: kyang1, on: Friday Aug 21, 2015 at 23:00 GMT

Extension specification should be moved out of signature format spec for the following reasons:

  1. Current description of extensions in the signature format is too specific to getAssertion method and FIDOAssertion object. It is inappropriate to refer to it for places where extensions are used in the context of makeCredential and AttestationStatement.
  2. The way that extensions shall be processed by both the client and the authenticator for makeCredential and getAssertion are the same. It doesn't make much sense to describe the same thing twice in two specifications.

If WebAPI is not a good place, platform requirement may be another option.
@equalsJeffH equalsJeffH added this to the ms-fido-v2.0-w3c milestone Mar 13, 2016
@equalsJeffH
Copy link
Contributor Author

Original poster: nadalin, on: Thursday Aug 27, 2015 at 19:36 GMT

For now we should leave it in a single document (signature is fine for now) and other documents should just reference as needed

@equalsJeffH
Copy link
Contributor Author

Original poster: rlin1, on: Friday Aug 28, 2015 at 16:31 GMT

Extensions are already defined in two different docs: signature-format and key-attestation.
And they (mostly) apply to attestation signatures.

@equalsJeffH
Copy link
Contributor Author

Original poster: equalsJeffH, on: Monday Dec 07, 2015 at 19:50 GMT

see also #108 #114 -- this remains an open issue the w3c web authn wg will need to address once it begins work. thus setting milestone to ms-fido-v2.0-w3c

@equalsJeffH equalsJeffH removed this from the ms-fido-v2.0-w3c milestone Mar 13, 2016
@nadalin nadalin added this to the SPWD milestone Mar 30, 2016
@vijaybh vijaybh modified the milestones: FPWD, SPWD Apr 13, 2016
@vijaybh
Copy link
Contributor

vijaybh commented Apr 13, 2016

Will be addressed as part of editorial moving-sections-around update.

vijaybh added a commit that referenced this issue Apr 19, 2016
@vijaybh
Editorial refactor of spec
ed0153d 
Initial proposal for how the spec could be organized to address #1.
Fixes #7, #9. I also removed text that was duplicated across signature
and attestation sections, and added some minimal glue in its place.

I also removed some bikeshed warnings (which could be seen in the
previous version by running bikeshed with the --debug option).

I have some more cleanups I would like to discuss, but would like to get
agreement on this direction first. If agreed, I will add whitespace
cleanups in a separate commit before merging to master.
agl pushed a commit that referenced this issue Feb 22, 2023
@sbweeden
Merge pull request #7 from w3c/main
dec92f1 
bring fork up to date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stat:OKtoDo type:editorial
Projects
None yet
Milestone
FPWD (WD-00)
Development

No branches or pull requests
3 participants
@equalsJeffH @nadalin @vijaybh