Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1076 - Don't confuse extension optionality in Sec 10 #1083

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Fix #1076 - Don't confuse extension optionality in Sec 10 #1083

merged 1 commit into from
Sep 20, 2018

Conversation

jcjones
Copy link
Contributor

@jcjones jcjones commented Sep 20, 2018 •
edited by pr-preview bot
Loading

Language from Mike Jones in #1076 (comment)

Preview | Diff

@jcjones jcjones added this to the PropRec milestone Sep 20, 2018
emlun
emlun approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have we considered "MAY" instead of "can"?

@akshayku
Copy link
Contributor

akshayku commented Sep 20, 2018 •
edited
Loading

+1 for "MAY".

@nadalin
Copy link
Contributor

nadalin commented Sep 20, 2018

@jcjones Please merge

@emlun emlun mentioned this pull request Sep 20, 2018
Closed
@emlun
Copy link
Member

emlun commented Sep 20, 2018

@nadalin You're welcome to ignore meta-PR jcjones#7 and go ahead to merge this if you want/need to.

@samuelweiler
Copy link
Member

LGTM. I like the MAY, also, but it doesn't matter.

@YubicoDemo YubicoDemo merged commit ee934de into w3c:master Sep 20, 2018
WebAuthnBot pushed a commit that referenced this pull request Sep 20, 2018
Built by Travis-CI: ee934de Merge pull request #1083 from jcjones/107…
693fd41 
…6-extension_marking
WebAuthnBot pushed a commit that referenced this pull request Sep 20, 2018
Built by Travis-CI: ee934de Merge pull request #1083 from jcjones/107…
5fee95d 
…6-extension_marking
@jcjones jcjones deleted the 1076-extension_marking branch September 21, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayku akshayku akshayku approved these changes

@emlun emlun emlun approved these changes

@selfissued selfissued Awaiting requested review from selfissued

Assignees

@jcjones jcjones

Labels
type:editorial
Projects
None yet
Milestone
PropRec
Development

Successfully merging this pull request may close these issues.
6 participants
@jcjones @akshayku @nadalin @emlun @samuelweiler @YubicoDemo