Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial proposal to fix #1287 #1289

Merged
merged 5 commits into from
Sep 11, 2019
Merged

Initial proposal to fix #1287 #1289

merged 5 commits into from
Sep 11, 2019

Conversation

sbweeden
Copy link
Contributor

@sbweeden sbweeden commented Aug 29, 2019 •
edited by pr-preview bot
Loading

Relax the requirement for RP's to reject responses containing unsolicited extensions

fix #1287

Preview | Diff

@sbweeden
Initial proposal to address w3c#1287 by relaxing the requirement for …
fcce611 
…RP's to reject responses containing unsolicited extensions.
@sbweeden sbweeden mentioned this pull request Aug 29, 2019
Closed
@sbweeden sbweeden added this to the L2-WD-02 milestone Sep 4, 2019
@sbweeden sbweeden changed the title Initial proposal to address #1287 Initial proposal to fix #1287 Sep 4, 2019
agl
agl approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@agl agl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. As mentioned on the call, I think a Note might be useful to give context, but this does the job.

@sbweeden
Added additional note further clarifying why unsolicited extensions m…
f4d2ed4 
…ay be present, and how the RP might deal with such a situation.
emlun
emlun reviewed Sep 5, 2019
View reviewed changes
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me; some minor polish suggestions inline.

Also, there's a "should" that should perhaps be a "MUST" instead - thoughts on that?

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
sbweeden and others added 3 commits September 6, 2019 10:20
@sbweeden @emlun
Update index.bs
8f5d7bd 
Co-Authored-By: Emil Lundberg <emil@emlun.se>
@sbweeden @emlun
Update index.bs
64a4d2a 
Co-Authored-By: Emil Lundberg <emil@emlun.se>
@sbweeden
Incorporate feedback from @emlun
dc0378b
equalsJeffH
equalsJeffH approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sbweeden !

@nadalin nadalin merged commit 32c216c into w3c:master Sep 11, 2019
WebAuthnBot pushed a commit that referenced this pull request Sep 11, 2019
Built by Travis-CI: 32c216c Merge pull request #1289 from sbweeden/sb…
d3e06d6 
…weeden_issue_1287
WebAuthnBot pushed a commit that referenced this pull request Sep 11, 2019
Built by Travis-CI: 32c216c Merge pull request #1289 from sbweeden/sb…
ae1f642 
…weeden_issue_1287
@sbweeden sbweeden deleted the sbweeden_issue_1287 branch October 21, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayku akshayku akshayku approved these changes

@emlun emlun emlun approved these changes

@equalsJeffH equalsJeffH equalsJeffH approved these changes

@agl agl agl approved these changes

Assignees

@sbweeden sbweeden

Labels
type:technical
Projects
None yet
Milestone
L2-WD-02
Development

Successfully merging this pull request may close these issues.

Browsers adding extensions.
6 participants
@sbweeden @agl @equalsJeffH @emlun @akshayku @nadalin