-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly state that RPs cannot in general choose attestation type/format #1660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. I agree we ought to make it explicitly clear that the authenticator chooses the attestation type&format. However, the proposed statement confuses attestation type&format with attestation conveyance, which is a different thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @emlun, nominally looks OK to me, but I wonder about the "and client" portion of the clause:
[=attestation statement format=] is chosen by the [=authenticator=] and [=client=]
...is that referring to the "none" attestation conveyance case where the client modifies the returned attestation statement? If so, I'm inclined to excise the "and [=client=]" and then it LGTM.
That and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since @equalsJeffH commented:
it seems like this is ready to merge. Thanks everyone! |
Fixes issue #1659.
Marking this as draft for now because I'm not entirely sure this addition is worth its weight. I'd like to hear what some others think.
Preview | Diff