Fix incorrect use of options variable: rename to pkOptions #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_§5.1.3. Create a New Credential_ and _§5.1.4. Use an Existing Credential to Make an Assertion_ both declare their **options** parameter as the `Credential[Creation|Request]Options` object inherited from CredMan: >**options** >This argument is a `CredentialCreationOptions` object whose >_options_.`publicKey` member contains a `PublicKeyCredentialCreationOptions` >object [...] Both also re-assign the _options_ variable: >Let _options_ be the value of _options_.`publicKey`. But both then also reference _options_.`signal`, which is a member of `Credential[Creation|Request]Options` but not `PublicKeyCredential[Creation|Request]Options`: >If _options_.`signal` is present and aborted, throw the _options_.`signal`’s abort reason. _§5.1.4. Use an Existing Credential to Make an Assertion_ also incorrectly references _options_.`mediation` in a similar way. This fixes the issue by introducing a new variable _pkOptions_ instead of re-assigning the existing variable _options_, so that _options_ can keep its original value.
emlun
changed the title
emlun
added
the
stat:puntable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1752. This is mutually exclusive with PR #1806. I couldn't decide which approach is better, but I'm slightly favouring this one over #1806.
This fixes the issue by introducing a new variable pkOptions instead of re-assigning the existing variable options, so that options can keep its original value.
Preview | Diff