Issue 1817 #1845
Merged
Issue 1817 #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bring fork up to date
agl
approved these changes
Feb 14, 2023
github-actions bot
added a commit
that referenced
this pull request
Feb 22, 2023
SHA: 6a2e2b4 Reason: push, by agl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1817 by dropping the copy of the authenticator output of DPK from the client extension output, and updating references to this field in extension processing to refer to the value directly from authenticator extension output in authData. Note that the signature field, which is unsigned authenticator output, still needs to be comunicated back to the WebAuthn client via client extension output.
Preview | Diff