Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder PublicKeyCredentialDescriptorJSON values to match PublicKeyCredentialDescriptor #2110

Merged

Conversation

MasterKale
Copy link
Contributor

@MasterKale MasterKale commented Aug 6, 2024

This PR rearranges the properties in the PublicKeyCredentialDescriptorJSON dictionary to match the ordering of its non-JSON representation PublicKeyCredentialDescriptor dictionary.

PublicKeyCredentialDescriptorJSON

Screenshot 2024-08-06 at 11 04 48 AM

PublicKeyCredentialDescriptor

Screenshot 2024-08-06 at 11 05 39 AM

Fixes #2082.


Preview | Diff

@MasterKale MasterKale requested a review from emlun August 6, 2024 18:06
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nadalin nadalin added this to the L3-WD-02 milestone Aug 7, 2024
@MasterKale MasterKale merged commit 2df9691 into main Aug 7, 2024
2 checks passed
@MasterKale MasterKale deleted the mm/2082-publickeycredentialdescriptorjson-ordering branch August 7, 2024 19:51
github-actions bot added a commit that referenced this pull request Aug 7, 2024
…orjson-ordering

SHA: 2df9691
Reason: push, by MasterKale

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align the order of fields in PublicKeyCredentialDescriptorJSON with PublicKeyCredentialDescriptor
5 participants