Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move topOrigin definition after crossOrigin #2114

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

emlun
Copy link
Member

@emlun emlun commented Aug 7, 2024

Fixes #2101. Web IDL dictionaries are insensitive to source definition order, so this does not change the semantic meaning of the Web IDL.


Preview | Diff

Copy link
Contributor

@zacknewman zacknewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nadalin nadalin added this to the L3-WD-02 milestone Aug 14, 2024
@emlun emlun merged commit 5f0701d into main Aug 14, 2024
2 checks passed
@emlun emlun deleted the issue-2101-toporigin-order branch August 14, 2024 19:21
github-actions bot added a commit that referenced this pull request Aug 14, 2024
SHA: 5f0701d
Reason: push, by emlun

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CollectedClientData fields are not ordered correctly and crossOrigin should be required
5 participants