Add userName and userDisplayName to webdriver #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksteele
approved these changes
Sep 18, 2024
|
Nina to fix the empty name / display name problem |
MasterKale
requested changes
Sep 24, 2024
pascoej
approved these changes
Sep 24, 2024
emlun
approved these changes
Sep 30, 2024
This PR adds the userName and userDisplayName properties to the webdriver's credential parameters. These properties are useful to test the new signalCurrentUserDetails method, both on WPTs and for web developers. Closes w3c#2143
nsatragno
force-pushed
the
10_webdriver_names
branch
from
5c2e0bc
to
146a63e
Compare
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 2, 2024
Add `userName` and `userDisplayName` to the WebAuthn devtools domain. These will be used to implement their webdriver counterparts. See w3c/webauthn#2148 Bug: 367915823 Change-Id: I39711d8114b752fe21ba8ce67379a74252b8eda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5898666 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/main@{#1363089}
MasterKale
approved these changes
Oct 2, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 7, 2024
Add userName and userDisplayName to the WebAuthn automation API on chromedriver. See w3c/webauthn#2148 Bug: 367915823 Change-Id: I2a09c5f169000340a86400156af9579e390b16c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905423 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/main@{#1364949}
T3-M4
pushed a commit
to bayandin/chromedriver
that referenced
this pull request
Oct 8, 2024
Add userName and userDisplayName to the WebAuthn automation API on chromedriver. See w3c/webauthn#2148 Bug: 367915823 Change-Id: I2a09c5f169000340a86400156af9579e390b16c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905423 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/main@{#1364949}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the userName and userDisplayName properties to the webdriver's credential parameters. These properties are useful to test the new signalCurrentUserDetails method, both on WPTs and for web developers.
Closes #2143
The following tasks have been completed:
-- This will be done as a follow-up
Implementation commitment:
Preview | Diff