Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QuotaExceededError from spec #449

Merged
merged 5 commits into from
May 5, 2017
Merged

Conversation

AngeloKai
Copy link
Contributor

@AngeloKai AngeloKai commented May 4, 2017

Remove QuotaExceededError per request by @leshi


Preview | Diff

@AngeloKai AngeloKai requested a review from jyasskin May 4, 2017 23:54
@jyasskin
Copy link
Member

jyasskin commented May 4, 2017

@leshi, I thought QuotaExceededError solved (or improved) one problem you pointed out with requiring resident keys: it lets the RP tell the user that their key storage is full. It's true that it's not as precise as one might want, but we can solve that by proposing a more precise error name into WebIDL.

https://w3c.github.io/mediacapture-main/getusermedia.html#overconstrainederror-object has another, more complex, precedent.

Or do you actually think that we should leave this vague for now (as this PR does), and come up with a more solid solution with more time to think?

Copy link
Member

@jyasskin jyasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks technically correct (although I haven't double-checked for Bikeshed errors), and I don't have a strong opinion about which error to return in this case.

@AngeloKai
Copy link
Contributor Author

AngeloKai commented May 5, 2017

@jyasskin This seems like a small issue. I prefer not letting this drag out our publication schedule. I'd prefer leaving this vague for now and making it more solid later.

@leshi
Copy link
Contributor

leshi commented May 5, 2017

@jyasskin,

I think the SelectionResponse variable was internal anyway. So RP wouldn't learn why things failed.

@AngeloKai AngeloKai requested a review from equalsJeffH May 5, 2017 01:23
@AngeloKai
Copy link
Contributor Author

Given that neither @leshi nor @jyasskin has a strong opinion on this, I will go ahead and merge it then.

@AngeloKai AngeloKai merged commit aa86843 into w3c:master May 5, 2017
WebAuthnBot pushed a commit that referenced this pull request May 5, 2017
@AngeloKai AngeloKai deleted the changeError branch May 8, 2017 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants