Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #692 #696

Merged
merged 3 commits into from
Nov 21, 2017
Merged

Fix issue #692 #696

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b98d1d
Fix initial part of step 18 of credentials.get()
emlun Nov 13, 2017
705e3d8
Fix references to |authenticatorSelection| members in step §5.1.3.18
emlun Nov 20, 2017
7b5b195
Merge branch 'master' into issue-692
emlun Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,21 +757,24 @@ When this method is invoked, the user agent MUST execute the following algorithm

1. Let |issuedRequests| be a new [=ordered set=].

1. If <code>|options|.{{MakePublicKeyCredentialOptions/authenticatorSelection}}</code> is
[=present|present=], [=set/for each=] |authenticator| that becomes available on this
platform during the lifetime of |lifetimeTimer| and do the following:
1. [=set/For each=] |authenticator| that becomes available on this platform during the lifetime of |lifetimeTimer|, do the
following:

Issue: The definitions of "lifetime of" and "becomes available" are intended to represent how
devices are hotplugged into (USB) or discovered by (NFC) browsers, and are under-specified.
Resolving this with good definitions or some other means will be addressed by resolving
[Issue #613](https://github.com/w3c/webauthn/issues/613).

1. If {{AuthenticatorSelectionCriteria/authenticatorAttachment}} is [=present|present=] and its value is not equal
to |authenticator|'s attachment modality, [=iteration/continue=].
1. If {{AuthenticatorSelectionCriteria/requireResidentKey}} is set to `true` and the |authenticator|
is not capable of storing a [=Client-Side-Resident Credential Private Key=], [=iteration/continue=].
1. If {{AuthenticatorSelectionCriteria/requireUserVerification}} is set to {{UserVerificationRequirement/required}} and the
|authenticator| is not capable of performing [=user verification=], [=iteration/continue=].
1. If <code>|options|.{{MakePublicKeyCredentialOptions/authenticatorSelection}}</code> is [=present=]:

1. If <code>|options|.{{MakePublicKeyCredentialOptions/authenticatorSelection}}.{{authenticatorAttachment}}</code> is
[=present|present=] and its value is not equal to |authenticator|'s attachment modality, [=iteration/continue=].
1. If <code>|options|.{{MakePublicKeyCredentialOptions/authenticatorSelection}}.{{requireResidentKey}}</code> is set to
`true` and the |authenticator| is not capable of storing a [=Client-Side-Resident Credential Private Key=],
[=iteration/continue=].
1. If <code>|options|.{{MakePublicKeyCredentialOptions/authenticatorSelection}}.{{requireUserVerification}}</code> is
set to {{UserVerificationRequirement/required}} and the |authenticator| is not capable of performing [=user
verification=], [=iteration/continue=].

1. Let |userVerification| be the <dfn>effective user verification requirement for credential creation</dfn>, a Boolean value,
as follows. If {{AuthenticatorSelectionCriteria/requireUserVerification}}
Expand Down