Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Encoded*Chunk interfaces immutable. #174

Merged
merged 5 commits into from
May 13, 2021
Merged

Conversation

chcunningham
Copy link
Collaborator

@chcunningham chcunningham commented Apr 9, 2021

Provides a readInto() method for copying the data out.

Fixes #80. Also, see #127.


Preview | Diff

Provides a readInto() method for copying the data out.

Fixes #80. Also, see #127.
@chcunningham
Copy link
Collaborator Author

FYI @sandersdan

Copy link
Collaborator

@aboba aboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 1742: s/repsenting/representing/

@chcunningham
Copy link
Collaborator Author

Line 1742: s/repsenting/representing/

Done! Thanks.

Copy link
Collaborator

@padenot padenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not sure about the naming. Did you name it this way because of some precedent in some other API ?

index.src.html Outdated Show resolved Hide resolved
index.src.html Outdated Show resolved Hide resolved
@chcunningham
Copy link
Collaborator Author

Editors call:

  • resolve, rename to copyTo() and merge.
  • VideoFrame, keep using "read" for historical match, discuss suffix (To, Back, ...) later in VF PR

@chcunningham chcunningham merged commit fcada57 into main May 13, 2021
@chcunningham chcunningham deleted the immutable_chunks branch May 13, 2021 22:56
github-actions bot added a commit that referenced this pull request May 13, 2021
SHA: fcada57
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 13, 2021
SHA: fcada57
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 13, 2021
SHA: fcada57
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request May 14, 2021
SHA: fcada57
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request May 14, 2021
SHA: fcada57
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request May 14, 2021
SHA: fcada57
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants