Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 27471 - Provide even more informative text over key wrapping? #40

Closed
mwatson2 opened this issue May 23, 2016 · 5 comments
Closed

Bug 27471 - Provide even more informative text over key wrapping? #40

mwatson2 opened this issue May 23, 2016 · 5 comments
Assignees

Comments

@mwatson2
Copy link
Collaborator

Bug 27471 from Bugzilla:

Just noting that I removed the following pre-CR from Section 14, as we have I believe resolved that we cannot address execution environment level issues in this spec after very long debate. That being said, informative text that clarifies that unwrapping unextractable trees are hard to guarantee without special treatment that is not to be normatively expected from the text (but could be provided by implementations in theory) might be useful. I also removed the reference from the example.

Or we could just keep the remark deleted.

REMOVED:

Editorial note:

ISSUE-35:

          The specification for wrapKey/unwrapKey does not specify how authors that do not trust  the execution environment may indicate required attributes for keys that are unwrapped. An example is unwrapping a key with a non-extractable key, marking  the newly unwrapped key as non extractable, and then further indicating that all keys unwrapped with the newly unwrapped key are also non-ex
@hhalpin
Copy link

hhalpin commented Jun 20, 2016

I do think we should note the unusual lack of guarantees around unwrapping wrapped keys, as otherwise developers may shot themselves in foot as pointed out by Graham Steel etc. earlier. Is this about right? "Wrapped keys are exported and so only extractable keys can be wrapped. Thus, unwrapped key material is extractable and it not guaranteed that usages for a key have been preserved after the key have been wrapped."

@hhalpin
Copy link

hhalpin commented Jun 20, 2016

For the export, it has extractable, but not for unwrapped. Could you hand a key to the test-suite to make sure you can unwrap a private key and maintain its un-extractability?

@mwatson2
Copy link
Collaborator Author

I'll make a proposal.

@mwatson2 mwatson2 self-assigned this Jul 11, 2016
mwatson2 added a commit to mwatson2/webcrypto that referenced this issue Sep 8, 2016
@mwatson2
Copy link
Collaborator Author

mwatson2 commented Sep 8, 2016

Please review PR #134.

This issue is that a JWK marked non-extractable cannot be created by the wrapKey method, because only extractable keys can be wrapped.

However, JWKs marked non-extractable that are created elsewhere can be unwrapped.

@ericroman920
Copy link

The note added in PR #134 LGTM.

That said, I don't think this behavior was ambiguous prior to the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants