Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add randomUUID method #285

Merged
merged 6 commits into from
Jan 26, 2022
Merged

add randomUUID method #285

merged 6 commits into from
Jan 26, 2022

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Oct 3, 2021

Merge sections from https://github.com/WICG/uuid describing randomUUID()
method.

Refs: WICG/uuid#27


Preview | Diff

spec/Overview.html Outdated Show resolved Hide resolved
@twiss
Copy link
Member

twiss commented Oct 6, 2021

Hey 👋 Thanks for the PR!
The syntax for referencing external concepts used here is a bit different than the rest of the spec, so I wanted to suggest some changes, but ran into some issues with respec, so I'll update our usage of respec first and then rebase and review this PR afterwards, if you don't mind.

@bcoe
Copy link
Contributor Author

bcoe commented Oct 6, 2021

so I'll update our usage of respec first and then rebase and review this PR afterwards

@twiss sounds great, I'm still learning the ins and outs of the respec syntax, so appreciate the direction.

@twiss
Copy link
Member

twiss commented Oct 7, 2021

I'm not an expert on ReSpec either 😅 But as long as we end up with a consistent document I'm happy :)

@twiss
Copy link
Member

twiss commented Oct 13, 2021

Hey 👋 I've rebased this PR, and made some editorial changes (mainly to bring the style more in line with the rest of the spec), and pushed them to the branch - let me know if you have any objections to these.

I've also somewhat simplified the wording for getting 16 random bytes - even though that brings it less in line with getRandomValues instead of more, but getRandomValues was explicitly written to support multiple types of TypedArrays, whereas that isn't necessary here.

Finally, this PR uses |foo| whereas the rest of the spec uses <var>foo</var>, but I like the former more so I've left it as is, probably we should update the rest of the spec to match after merging this, though :)

spec/Overview.html Outdated Show resolved Hide resolved
@bcoe
Copy link
Contributor Author

bcoe commented Oct 14, 2021

I've also somewhat simplified the wording for getting 16 random bytes - even though that brings it less in line with getRandomValues instead of more, but getRandomValues was explicitly written to support multiple types of TypedArrays, whereas that isn't necessary here.

@twiss I like this change 👍

Hey 👋 I've rebased this PR, and made some editorial changes (mainly to bring the style more in line with the rest of the spec), and pushed them to the branch - let me know if you have any objections to these.

Thank you for doing this 👏

For next steps, I'm assuming we should leave in draft until discussions take place regrading Web Crypto's charter? (CC: @marcoscaceres).

@bcoe
Copy link
Contributor Author

bcoe commented Jan 19, 2022

@twiss @annevk just checking in, I think this continues to be blocked on the 2021 charter? (any updates for someone who's not tuned into w3c governance.)

@annevk
Copy link
Member

annevk commented Jan 21, 2022

Yeah, @samuelweiler would be better equipped to talk about that.

@marcoscaceres
Copy link
Member

Progress on the recharter can be tracked here:
w3c/strategy#253

In the meantime, it's fine to do the final reviews and we should just merge this.

We can regenerate the editor's draft here on Github for now and republish "officially" on /TR/ once the rechartering actually happens.

@bcoe bcoe marked this pull request as ready for review January 25, 2022 19:17
@bcoe bcoe requested review from twiss and annevk January 25, 2022 19:18
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still looks good, but I have a style nit you might want to address before landing.

spec/Overview.html Outdated Show resolved Hide resolved
@twiss twiss merged commit c5188d7 into w3c:main Jan 26, 2022
github-actions bot added a commit that referenced this pull request Jan 26, 2022
SHA: c5188d7
Reason: push, by @twiss

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@twiss
Copy link
Member

twiss commented Jan 26, 2022

Thanks again for all the work here! 😊

tidoust added a commit to w3c/browser-specs that referenced this pull request Jan 27, 2022
The randomUUID method was merged in the WebCrypto API spec, see:
w3c/webcrypto#285

This update adds the WICG repository to the ignore list.
tidoust added a commit to w3c/browser-specs that referenced this pull request Jan 27, 2022
The randomUUID method was merged in the WebCrypto API spec, see:
w3c/webcrypto#285

This update adds the WICG repository to the ignore list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants