browsingContext.print: minimum page size: round down instead of up
#536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small correction of #534. The minimum page size is (2.54 / 72) = 0.03527... We need to round it down to 0.0352 instead of up to 0.0353 in order to make 0.03527 an acceptable value.
thiagowfx
requested review from
whimboo,
OrKoN,
Lightning00Blade and
jrandolf-2
thiagowfx
changed the title
browsingContext.print: minimum page size: round down instead of up
whimboo
approved these changes
Sep 12, 2023
Lightning00Blade
approved these changes
Sep 12, 2023
github-actions bot
added a commit
that referenced
this pull request
Sep 12, 2023
) SHA: 43abc3c Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small correction of #534.
The minimum page size is (2.54 / 72) = 0.03527...
We need to round it down to 0.0352 instead of up to 0.0353 in order to make 0.03527 (1x1 point) an acceptable value.
Preview | Diff