Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain writer.js #122

Merged
merged 23 commits into from
Dec 16, 2017
Merged

Maintain writer.js #122

merged 23 commits into from
Dec 16, 2017

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Dec 15, 2017

Fixes #109

This PR:

  • converts old ES5 syntax to ES2015+
  • add tests (by writing IDLs from existing JSON AST, reparsing them and comparing them to the original ASTs)
  • fix bugs and support new types to pass the tests

PS: Note that this does not test whitespaces yet as it's not fully understood yet (#97). It will be done on a later PR.

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this is gone

@saschanaz saschanaz merged commit 0c103b3 into develop Dec 16, 2017
@saschanaz saschanaz deleted the writer branch December 16, 2017 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants