Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extended attributes identifier lists #29

Merged
merged 4 commits into from
May 21, 2015

Conversation

tobie
Copy link
Member

@tobie tobie commented May 20, 2015

This adds support for constructs of the form:

[Exposed=(Window,Worker)]

which were kind of supported, but not documented.

The proposed JSON syntax for the above would be:

{
    "name": "Exposed",
    "arguments": null,
    "rhs": {
        "type": "identifier-list",
        "value": [
            "Global",
            "Worker"
        ]
   }
}

This introduces a new Right Hand Side type, the identifier list. I'm happy to change the JSON syntax, though, if so, please LMK.

Note that currently, the above would be rendered as:

{
    "name": "Exposed",
    "arguments": null,
    "rhs": [
        "Global",
        "Worker"
    ]
}

@jyasskin
Copy link
Member

Looks fine to me.

@tobie
Copy link
Member Author

tobie commented May 20, 2015

Oh, had missed your review here. Thanks!

Just want to make sure @darobin is confortable with the introduction of the identifier-list RHS type.

darobin added a commit that referenced this pull request May 21, 2015
Add support for extended attributes identifier lists
@darobin darobin merged commit 240a9b2 into w3c:develop May 21, 2015
@tobie tobie deleted the ext-attrs branch May 21, 2015 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants