Prevent duplicates in dfns extracts #783
Comments
tidoust
added a commit
to w3c/reffy
that referenced
this issue
Nov 9, 2022
This makes the dfns extraction code skip over a re-defined term (same linking text, same type, same namespace), and report a warning when a duplicate dfn is encountered and skipped. Warnings are easily glossed over but we don't really have a better mechanism in place right now to report issues found during extractions. Apart from making the whole extraction fail that is, which seems overkill. Fixes w3c/webref#783
tidoust
added a commit
to w3c/reffy
that referenced
this issue
Nov 9, 2022
This makes the dfns extraction code skip over a re-defined term (same linking text, same type, same namespace), and report a warning when a duplicate dfn is encountered and skipped. Warnings are easily glossed over but we don't really have a better mechanism in place right now to report issues found during extractions. Apart from making the whole extraction fail that is, which seems overkill. Fixes w3c/webref#783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #780 for context.
The crawler may end up extracting duplicate definitions when a page in a multi-pages spec starts redirecting to another page and the redirecting page is still listed as a concrete page in browser-specs.
Detecting duplicate definitions in a spec is easy (same
linkingText, sametype, samefor). We don't have a curation step in place for definitions. Extraction should rather probably just pick up one of the definitions when that happens and report a warning that a duplicate definition exists. One potential hiccup is that we don't really pay attention to such warnings, so a failure might be preferable.The text was updated successfully, but these errors were encountered: