metadata: add payloadType #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a payloadType attribute to the metadata. This is the RTP payload type from the RTP header, with a range of [0,127]. This can be used to determine the codec of the encoded data and hence its format.
|
hrm: https://w3c.github.io/webrtc-stats/#codec-dict* makes this an unsigned long but the range is really (half a) an octet. |
johzzy
pushed a commit
to johzzy/webrtc-mirror
that referenced
this pull request
Aug 25, 2021
spec PR: w3c/webrtc-encoded-transform#117 Bug: webrtc:13077 Change-Id: I81d79201cea353c26ea840e92c0deec7c7253b8b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229020 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#34844}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 26, 2021
exposes the payload type in the encoded audio/video frame metadata spec PR: w3c/webrtc-encoded-transform#117 BUG=webrtc:13077 Change-Id: I17340aec0b18637d7c1f3222add496a8aeb346ae
|
Ash-nazg issue: this is definitely a substantial contribution. |
|
@fippo can you get in touch by email to discuss our options wrt IPR? |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 26, 2021
exposes the payload type in the encoded audio/video frame metadata spec PR: w3c/webrtc-encoded-transform#117 BUG=webrtc:13077 Change-Id: I17340aec0b18637d7c1f3222add496a8aeb346ae
|
to give a quick update on the IPR situation: @fippo has gotten approval to make the proper IPR commitment, but the system can only collect it once the spec has been published as a FPWD (which hopefully should happen soon) |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 3, 2021
exposes the payload type in the encoded audio/video frame metadata spec PR: w3c/webrtc-encoded-transform#117 BUG=webrtc:13077 Change-Id: I17340aec0b18637d7c1f3222add496a8aeb346ae
alvestrand
approved these changes
Sep 6, 2021
|
🎉 |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 7, 2021
exposes the payload type in the encoded audio/video frame metadata spec PR: w3c/webrtc-encoded-transform#117 BUG=webrtc:13077 Change-Id: I17340aec0b18637d7c1f3222add496a8aeb346ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3118568 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Tony Herre <toprice@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#918748}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 7, 2021
exposes the payload type in the encoded audio/video frame metadata spec PR: w3c/webrtc-encoded-transform#117 BUG=webrtc:13077 Change-Id: I17340aec0b18637d7c1f3222add496a8aeb346ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3118568 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Tony Herre <toprice@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#918748}
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Sep 7, 2021
exposes the payload type in the encoded audio/video frame metadata spec PR: w3c/webrtc-encoded-transform#117 BUG=webrtc:13077 Change-Id: I17340aec0b18637d7c1f3222add496a8aeb346ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3118568 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Tony Herre <toprice@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#918748}
|
IPR bot now happy, yay 🎉 |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 22, 2021
… a=testonly Automatic update from web-platform-tests insertable streams: expose payload type exposes the payload type in the encoded audio/video frame metadata spec PR: w3c/webrtc-encoded-transform#117 BUG=webrtc:13077 Change-Id: I17340aec0b18637d7c1f3222add496a8aeb346ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3118568 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Tony Herre <toprice@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#918748} -- wpt-commits: f2da2a889acbbf73f7f81ca5d93a7b7588a5683a wpt-pr: 30191
|
"I signed it" (thanks subu) :-) |
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Sep 24, 2021
… a=testonly Automatic update from web-platform-tests insertable streams: expose payload type exposes the payload type in the encoded audio/video frame metadata spec PR: w3c/webrtc-encoded-transform#117 BUG=webrtc:13077 Change-Id: I17340aec0b18637d7c1f3222add496a8aeb346ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3118568 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Tony Herre <toprice@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#918748} -- wpt-commits: f2da2a889acbbf73f7f81ca5d93a7b7588a5683a wpt-pr: 30191
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
exposes the payload type in the encoded audio/video frame metadata spec PR: w3c/webrtc-encoded-transform#117 BUG=webrtc:13077 Change-Id: I17340aec0b18637d7c1f3222add496a8aeb346ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3118568 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Tony Herre <toprice@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#918748}
github-actions bot
added a commit
that referenced
this pull request
Jan 27, 2022
SHA: f80a936 Reason: push, by @alvestrand Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
exposes the payload type in the encoded audio/video frame metadata spec PR: w3c/webrtc-encoded-transform#117 BUG=webrtc:13077 Change-Id: I17340aec0b18637d7c1f3222add496a8aeb346ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3118568 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Tony Herre <toprice@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#918748} NOKEYCHECK=True GitOrigin-RevId: fb399e309c1884f6802fb606944679a7c90f0e94
daemory
pushed a commit
to dangxiwang/webrtc
that referenced
this pull request
Apr 19, 2024
spec PR: w3c/webrtc-encoded-transform#117 Bug: webrtc:13077 Change-Id: I81d79201cea353c26ea840e92c0deec7c7253b8b
daemory
pushed a commit
to dangxiwang/webrtc
that referenced
this pull request
Apr 19, 2024
spec PR: w3c/webrtc-encoded-transform#117 Bug: webrtc:13077 Change-Id: I81d79201cea353c26ea840e92c0deec7c7253b8b
daemory
pushed a commit
to dangxiwang/webrtc
that referenced
this pull request
Apr 19, 2024
spec PR: w3c/webrtc-encoded-transform#117 Bug: webrtc:13077 Change-Id: I81d79201cea353c26ea840e92c0deec7c7253b8b
daemory
pushed a commit
to dangxiwang/webrtc
that referenced
this pull request
Apr 19, 2024
spec PR: w3c/webrtc-encoded-transform#117 Bug: webrtc:13077 Change-Id: I81d79201cea353c26ea840e92c0deec7c7253b8b
daemory
pushed a commit
to dangxiwang/webrtc
that referenced
this pull request
Apr 19, 2024
spec PR: w3c/webrtc-encoded-transform#117 Bug: webrtc:13077 Change-Id: I81d79201cea353c26ea840e92c0deec7c7253b8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a payloadType attribute to the metadata. This is the RTP payload type
from the RTP header, with a range of [0,127].
This can be used to determine the codec of the encoded data and hence its
format.
Preview | Diff