Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaceTrack: Never negotiate when replacing an ended track? #1697

Closed
adam-be opened this issue Dec 14, 2017 · 5 comments
Closed

replaceTrack: Never negotiate when replacing an ended track? #1697

adam-be opened this issue Dec 14, 2017 · 5 comments
Assignees

Comments

@adam-be
Copy link
Member

adam-be commented Dec 14, 2017

The spec says:

Negotiation is not needed if withTrack is null or if the sender's existing track is ended
(which appears as though the track was muted).

The first part, with withTrack null is handled further down in the steps, but is the second part, with track ended, safe?

@aboba
Copy link
Contributor

aboba commented Dec 21, 2017

@adam-be If we accept that replaceTrack can sometimes require negotiation, it seems like those same scenarios can occur if the existing track is ended.

@adam-be
Copy link
Member Author

adam-be commented Dec 21, 2017

That's my concern as well

@stefhak
Copy link
Contributor

stefhak commented Jan 2, 2018

I don't understand why the fact that the existing track has ended would mean that negotiation would never be needed. Is the thinking that if a track has ended (and silence/black is sent) you can never recover via a replaceTrack? I.e. silence/blackness would continue regardless of the state of withTrack?
That does not make sense to me, I think or if the sender's existing track is ended (which appears as though the track was muted) should be removed.

@aboba
Copy link
Contributor

aboba commented Jan 2, 2018

@stefhak I agree.

@adam-be
Copy link
Member Author

adam-be commented Jan 4, 2018

Is the thinking that if a track has ended (and silence/black is sent) you can never recover via a replaceTrack?

@stefhak, that's the only reasonable explanation I can think of.

@aboba aboba closed this as completed Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants