Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IceCandidate.toJson method refers to "description" attribute #1786

Closed
alvestrand opened this issue Mar 5, 2018 · 0 comments
Closed

IceCandidate.toJson method refers to "description" attribute #1786

alvestrand opened this issue Mar 5, 2018 · 0 comments
Labels
Editorial PR exists

Comments

@alvestrand
Copy link
Contributor

The toJson method of RTCIceCandidate says:

For each attribute identifier attr in «"candidate", "sdpMid", "sdpMLineIndex", "description"»:
Let value be the result of getting the underlying value of the attribute identified by attr, given this RTCIceCandidate object.
Set json[attr] to value.

The attribute "description" occurs nowhere else. It should probably be "usernameFragment".
fippo added a commit to fippo/webrtc-pc that referenced this issue Mar 5, 2018
@fippo
fix RTCIceCandidate.toJson description
da3039f 
which erroneously refers to a description property. Fixes w3c#1786
@fippo fippo mentioned this issue Mar 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Editorial PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alvestrand @burnburn