Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mid from sender/receiver #358

Closed
stefhak opened this issue Oct 29, 2015 · 6 comments
Closed

Remove mid from sender/receiver #358

stefhak opened this issue Oct 29, 2015 · 6 comments

Comments

@stefhak
Copy link
Contributor

stefhak commented Oct 29, 2015

Has been proposed it belongs to the Transceiver and could be removed from Senders/Receivers.

@pthatcherg
Copy link
Contributor

Originally I said that without the mid, it would be impossible to know which sender matched with which transceiver, but I realized that it wrong. We could always just do "transceiver.sender === sender" or "transceiver.receiver === receiver" if we mark these as "same object", as Martin suggested we do.

So, I agree we should remove the mid and mark transceiver.receiver and .sender as "same object".

@alvestrand
Copy link
Contributor

The only issue with that that I can see is that the mid is also a configuration value for RTPsender - it tells it what to put into the "mid" header extension.
It would be OK for the transceiver to have the "master copy" of the mid value, and configure the RTPSender on creation - and there's actually no need to expose this value at the API for 1.0, so after this conversation, I conclude that we can remove it from the API in version 1.0.

@pthatcherg
Copy link
Contributor

By the way, ORTC has an MID (called muxId) on the RtpSender.getParameters/setParameters. We could easily have the same thing, but I don't see a need for it.

@juberti
Copy link
Contributor

juberti commented Oct 30, 2015

So how does RtpSender learn the mid? Through the ctor?

@pthatcherg
Copy link
Contributor

If it needs it, it can iterate over the transceivers and find the one with
transceiver.sender === sender.

On Thu, Oct 29, 2015 at 10:05 PM, Justin Uberti notifications@github.com
wrote:

So how does RtpSender learn the mid? Through the ctor?


Reply to this email directly or view it on GitHub
#358 (comment).

@stefhak
Copy link
Contributor Author

stefhak commented Dec 16, 2015

mid is now gone from the sender and receiver APIs (this change has not yet propagated into the Editor's draft though).

@stefhak stefhak closed this as completed Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants