Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCPeerConnectionState is a better home for "closed" than RTCSignalingState is #530

Closed
adam-be opened this issue Mar 2, 2016 · 2 comments
Closed

RTCPeerConnectionState is a better home for "closed" than RTCSignalingState is #530

adam-be opened this issue Mar 2, 2016 · 2 comments
Assignees
@adam-be
Labels
Needs assignee action

Comments

@adam-be
Copy link
Member

adam-be commented Mar 2, 2016

enum RTCSignalingState {
"stable",
"have-local-offer",
"have-remote-offer",
"have-local-pranswer",
"have-remote-pranswer",
"closed" // <-- do I belong here?
};

enum RTCPeerConnectionState {
"new",
"connecting",
"connected",
"disconnected",
"failed"
};
@alvestrand
Copy link
Contributor

Let's make a PR to move.

@alvestrand alvestrand mentioned this issue Mar 10, 2016
Closed
@alvestrand
Copy link
Contributor

Duplicate of #389

@alvestrand alvestrand mentioned this issue Mar 10, 2016
Closed
alvestrand added a commit that referenced this issue Apr 14, 2016
@alvestrand
Merge pull request #553 from adam-be/move-closed-state
0e0fceb 
Move 'closed' state from RTCSignalingState to RTCPeerConnectionState (issue #530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adam-be adam-be

Labels
Needs assignee action
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dontcallmedom @alvestrand @adam-be