Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTMF: duration and interToneGap attributes: Do we need them?` #843

Closed
aboba opened this issue Sep 29, 2016 · 4 comments
Closed

DTMF: duration and interToneGap attributes: Do we need them?` #843

aboba opened this issue Sep 29, 2016 · 4 comments
Labels
PR exists

Comments

@aboba
Copy link
Contributor

aboba commented Sep 29, 2016

Do we need the duration and interToneGap attributes?
@fluffy
Copy link
Contributor

fluffy commented Oct 5, 2016

I can't see any reason we need the attributes (still need the at least the duration parameter in the function call)

@aboba aboba mentioned this issue Oct 5, 2016
Closed
aboba added a commit that referenced this issue Oct 5, 2016
@aboba
Remove duration and interToneGap attributes
a567bfb 
Fix for Issue #843
@aboba aboba mentioned this issue Oct 5, 2016
Merged
@aboba aboba added the PR exists label Oct 5, 2016
@alvestrand
Copy link
Contributor

I think removing them makes the API simpler and no less powerful, so I'm happy to see them go.

@alvestrand
Copy link
Contributor

Closed by #852

@smaug----
Copy link

Just a comment from someone who reviews often webidl changes in Gecko: why is the API being changed so often? Does any vendor have data whether the attributes here are used and whether it is safe to remove them?
It is unusual for web specs to be changed so often after there are implementations shipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fluffy @alvestrand @aboba @smaug----