Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offerToReceive* as legacy extensions #1005

Merged
merged 2 commits into from
Feb 2, 2017
Merged

Conversation

alvestrand
Copy link
Contributor

Closes #709

webrtc.html Outdated
<p>
When this is given a non-false value, and no outgoing track of
type "audio" is attached to the PeerConnection, createOffer()
will behave as if addTransceiver("audio") had been called prior
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"called once prior"? We said the offer would contain only one receive-only m-line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if there is an outgoing track of type "audio"? Nothing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if conditions are not satisfied, nothing happens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added a precondition that no existing recv-able media section exists. Otherwise, doing a re-offer with offerToReceive=true would add an extra media section for each re-offer, and I don't think that was the intended behavior.

webrtc.html Outdated
<p>
When this is given a non-false value, and no outgoing track of
type "audio" is attached to the PeerConnection, createOffer()
will behave as if addTransceiver("video") had been called prior
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dito.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean "no outgoing track of type audio" or "no outgoing track of type video"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected to "video".

@stefhak
Copy link
Contributor

stefhak commented Jan 26, 2017

Had a minor comment, LGTM otherwise.

@alvestrand
Copy link
Contributor Author

Editors meeting: Harald to fix typos and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants