-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add offerToReceive* as legacy extensions #1005
Conversation
webrtc.html
Outdated
<p> | ||
When this is given a non-false value, and no outgoing track of | ||
type "audio" is attached to the PeerConnection, createOffer() | ||
will behave as if addTransceiver("audio") had been called prior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"called once prior"? We said the offer would contain only one receive-only m-line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if there is an outgoing track of type "audio"? Nothing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if conditions are not satisfied, nothing happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added a precondition that no existing recv-able media section exists. Otherwise, doing a re-offer with offerToReceive=true would add an extra media section for each re-offer, and I don't think that was the intended behavior.
webrtc.html
Outdated
<p> | ||
When this is given a non-false value, and no outgoing track of | ||
type "audio" is attached to the PeerConnection, createOffer() | ||
will behave as if addTransceiver("video") had been called prior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dito.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean "no outgoing track of type audio" or "no outgoing track of type video"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected to "video".
Had a minor comment, LGTM otherwise. |
Editors meeting: Harald to fix typos and merge. |
Closes #709