Always update the RTCRtpContributingSource for SSRCs. #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes w3c#1091. As described in the issue, there may be cases where an application wants to know the SSRC audio level, even when a CSRC is present in the packet.
|
LGTM. |
|
LGTM |
|
@taylor-b Do we need to update the PR now that we're going to use getSources() to retrieve the SSRC info? |
|
@aboba I don't think it hurts to merge this now, and do the CSRC/SSRC split in a separate PR. |
|
Issue #1111 filed on the update strategy. |
This was referenced Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091.
As described in the issue, there may be cases where an application
wants to know the SSRC audio level, even when a CSRC is present in the
packet.