-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark pranswer as a "feature atrisk" #1110
Conversation
Fix for Issue #1106
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
webrtc.html
Outdated
@@ -3446,7 +3446,7 @@ | |||
<div> | |||
<pre class="idl">enum RTCSdpType { | |||
"offer", | |||
"pranswer", | |||
"pranswer", //Feature at risk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Space after "//"
The demo of pr-answer is https://webrtc.github.io/samples/src/content/peerconnection/pr-answer/ |
@alvestrand: for clarification, are you saying this is in Chrome? It's not in Firefox, but that's a defect, not a plan. |
@ekr could you expand a bit? Are you saying pranswer will be implemented in Firefox? The demo at https://webrtc.github.io/samples/src/content/peerconnection/pr-answer/ works in Chrome when I test, so it looks like FF would be the second implementation. |
@ekr @jan-ivar @martinthomson could any of you comment on whether pranswer is in the plans for Firefox? |
Given we got no input from Mozilla I think we should merge this one. |
You should revert this. We do intend to implement this, I just missed your question. |
@ekr thanks for feedback. I agree, unless Chrome plans to remove pr-answer we should revert this. |
Fix for Issue #1106