Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark pranswer as a "feature atrisk" #1110

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Mark pranswer as a "feature atrisk" #1110

merged 2 commits into from
Apr 20, 2017

Conversation

aboba
Copy link
Contributor

@aboba aboba commented Apr 5, 2017

Fix for Issue #1106

Copy link
Contributor

@taylor-b taylor-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

webrtc.html Outdated
@@ -3446,7 +3446,7 @@
<div>
<pre class="idl">enum RTCSdpType {
"offer",
"pranswer",
"pranswer", //Feature at risk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Space after "//"

@alvestrand
Copy link
Contributor

@ekr
Copy link
Contributor

ekr commented Apr 7, 2017

@alvestrand: for clarification, are you saying this is in Chrome? It's not in Firefox, but that's a defect, not a plan.

@stefhak
Copy link
Contributor

stefhak commented Apr 9, 2017

@ekr could you expand a bit? Are you saying pranswer will be implemented in Firefox?

The demo at https://webrtc.github.io/samples/src/content/peerconnection/pr-answer/ works in Chrome when I test, so it looks like FF would be the second implementation.

@stefhak
Copy link
Contributor

stefhak commented Apr 13, 2017

@ekr @jan-ivar @martinthomson could any of you comment on whether pranswer is in the plans for Firefox?

@stefhak
Copy link
Contributor

stefhak commented Apr 19, 2017

Given we got no input from Mozilla I think we should merge this one.

@aboba aboba merged commit 7921d40 into master Apr 20, 2017
@ekr
Copy link
Contributor

ekr commented Apr 24, 2017

You should revert this. We do intend to implement this, I just missed your question.

@stefhak
Copy link
Contributor

stefhak commented Apr 25, 2017

@ekr thanks for feedback. I agree, unless Chrome plans to remove pr-answer we should revert this.

aboba added a commit that referenced this pull request Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants