Fire the "track" event from a queued task. #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes w3c#1135. This ensures that by the time the event is fired, the stream in the event has a full list of tracks.
taylor-b
added a commit
to taylor-b/webrtc-pc
that referenced
this pull request
Aug 9, 2017
Fixes w3c#1508. This was the behavior before, but I accidentally broke it in PR w3c#1136. This ensures that if, for example, a description is applied with audio/video tracks in the same stream, the order of events is: 1. "track" event with audio track, and stream that contains both tracks. 2. "track" event with video track, and stream that contains both tracks. 3. SRD promise resolves.
taylor-b
added a commit
to taylor-b/webrtc-pc
that referenced
this pull request
Aug 31, 2017
Fixes w3c#1508. This was the behavior before, but I accidentally broke it in PR w3c#1136. This ensures that if, for example, a description is applied with audio/video tracks in the same stream, the order of events is: 1. "track" event with audio track, and stream that contains both tracks. 2. "track" event with video track, and stream that contains both tracks. 3. SRD promise resolves.
taylor-b
added a commit
to taylor-b/webrtc-pc
that referenced
this pull request
Sep 11, 2017
Fixes w3c#1508. This was the behavior before, but I accidentally broke it in PR w3c#1136. This ensures that if, for example, a description is applied with audio/video tracks in the same stream, the order of events is: 1. "track" event with audio track, and stream that contains both tracks. 2. "track" event with video track, and stream that contains both tracks. 3. SRD promise resolves.
taylor-b
added a commit
that referenced
this pull request
Sep 12, 2017
* Ensure that "track" events fire before the SRD promise resolves. Fixes #1508. This was the behavior before, but I accidentally broke it in PR #1136. This ensures that if, for example, a description is applied with audio/video tracks in the same stream, the order of events is: 1. "track" event with audio track, and stream that contains both tracks. 2. "track" event with video track, and stream that contains both tracks. 3. SRD promise resolves. * Put enums in <code> blocks. * Don't queue a task to update the muted state. * Add missing quotes and <code> tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1135.
This ensures that by the time the event is fired, the stream in the
event has a full list of tracks.