Fix optional indicator for RTCPeerConnectionIceEventInit argument #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the WebIDL definition of the constructor, the argument RTCPeerConnectionIceEventInit is optional. But in the argument table it is shown as non-optional.
|
Marked as non-substantive for IPR from ash-nazg. |
|
LGTM. |
|
@soareschen you should join the group to get past the IPR issues. |
|
Thanks. @agouaillard is working on adding me to the group. |
|
ongoing guys, sorry. E-mail sent separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the WebIDL definition of the constructor, the argument
RTCPeerConnectionIceEventInitis optional. But in the argument table it is shown as non-optional.